Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to v2, addon. Just wrap fetch. #754

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4f8c508
Just wrap fetch
NullVoxPopuli Nov 5, 2024
3f7b708
Delete most of the old ember-fetch, show an ideal new version
NullVoxPopuli Nov 5, 2024
061807b
Add test-app
NullVoxPopuli Nov 5, 2024
43412c3
Move old tests into the test-app
NullVoxPopuli Nov 5, 2024
33f69b5
Move old tests into the test-app
NullVoxPopuli Nov 5, 2024
a3cbc17
Fix workflow
NullVoxPopuli Nov 5, 2024
5b91d51
Add errors and serialize-query-params
NullVoxPopuli Nov 5, 2024
545e53b
Delete the code that was in the dummy app, it was toooo deprecated
NullVoxPopuli Nov 5, 2024
3edf034
Delete tests for deleted utils
NullVoxPopuli Nov 5, 2024
b9e4556
Remove ember-data
NullVoxPopuli Nov 5, 2024
689dc9e
Don't import AbortController
NullVoxPopuli Nov 5, 2024
33a9273
Update tests
NullVoxPopuli Nov 5, 2024
56ef4a9
Remove pretender and related testing
NullVoxPopuli Nov 5, 2024
511b800
Don't block tests on lints
NullVoxPopuli Nov 5, 2024
c0cd6f7
Don't block tests on lints
NullVoxPopuli Nov 5, 2024
b888455
Re-add the ember-try config
NullVoxPopuli Nov 6, 2024
8b464af
Delete dummy app
NullVoxPopuli Nov 6, 2024
e62bd5d
Tell emebr-try to usePnpm
NullVoxPopuli Nov 6, 2024
dd0c220
Lint:Fix the serialize query params test
NullVoxPopuli Nov 6, 2024
4554211
Delete AbortController test, we don't need to test built ins
NullVoxPopuli Nov 6, 2024
de60890
Set the ember-cli versions for older ember
NullVoxPopuli Nov 6, 2024
2560847
Set the ember-cli versions for older ember
NullVoxPopuli Nov 6, 2024
e87fe0a
Update ember-try for 3.28
NullVoxPopuli Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

root = true


[*]
end_of_line = lf
charset = utf-8
Expand Down
9 changes: 0 additions & 9 deletions .ember-cli

This file was deleted.

16 changes: 2 additions & 14 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,22 +1,10 @@
# unconventional js
/blueprints/*/files/
/vendor/
**/*.d.ts

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/
/declarations/

# misc
/coverage/
!.*

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try

test/fixtures
71 changes: 71 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
'use strict';

module.exports = {
root: true,
// Only use overrides
// https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs
overrides: [
{
files: ['**/*.js'],
env: { browser: true },
parser: '@babel/eslint-parser',
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
requireConfigFile: false,
babelOptions: {
root: __dirname,
},
},
plugins: ['ember', 'import'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:prettier/recommended',
],
rules: {
// require relative imports use full extensions
'import/extensions': ['error', 'always', { ignorePackages: true }],
// Add any custom rules here
},
},
{
files: ['**/*.gjs'],
parser: 'ember-eslint-parser',
plugins: ['ember', 'import'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:ember/recommended-gjs',
'plugin:prettier/recommended',
],
rules: {
// require relative imports use full extensions
'import/extensions': ['error', 'always', { ignorePackages: true }],
// Add any custom rules here
},
},
// node files
{
files: [
'./.eslintrc.cjs',
'./.prettierrc.cjs',
'./.template-lintrc.cjs',
'./addon-main.cjs',
],
parserOptions: {
sourceType: 'script',
},
env: {
browser: false,
node: true,
},
plugins: ['n'],
extends: [
'eslint:recommended',
'plugin:n/recommended',
'plugin:prettier/recommended',
],
},
],
};
74 changes: 0 additions & 74 deletions .eslintrc.js

This file was deleted.

100 changes: 27 additions & 73 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,98 +16,52 @@ jobs:
name: "Linting"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn lint:js
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm lint

ember-tests:
needs: lint
name: "Tests: ubuntu (node@${{ matrix.node-version }})"
tests:
name: "Tests"
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["12"]

steps:
- uses: actions/checkout@v2
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn test

prefer-native-tests:
needs: ember-tests
name: "PREFER_NATIVE=true Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["12"]

steps:
- uses: actions/checkout@v2
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --non-interactive
- run: PREFER_NATIVE=true yarn test

native-promise-tests:
needs: ember-tests
name: "NATIVE_PROMISE=true Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["12"]

steps:
- uses: actions/checkout@v2
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --non-interactive
- run: NATIVE_PROMISE=true yarn test

node-tests:
needs: ember-tests
name: "Node Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ["12"]

steps:
- uses: actions/checkout@v2
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn run test:node
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm test:ember
working-directory: test-app

try-scenarios:
name: Tests - ${{ matrix.ember-try-scenario }}
timeout-minutes: 60
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.allow-failure }}
needs: ember-tests
needs: tests

strategy:
fail-fast: true
matrix:
ember-try-scenario:
- ember-lts-3.4
- ember-lts-3.8
- ember-lts-3.12
- ember-lts-3.16
- ember-lts-3.20
- ember-lts-3.24
# - ember-lts-3.4
# - ember-lts-3.8
# - ember-lts-3.12
# - ember-lts-3.16
# - ember-lts-3.20
# - ember-lts-3.24
- ember-lts-3.28
# - ember-lts-4.4
# - ember-lts-4.8
- ember-lts-4.12
# - ember-lts-5.4
# - ember-lts-5.8
- ember-lts-5.12
- ember-release
- ember-beta
allow-failure: [false]
include:
- ember-try-scenario: ember-canary
allow-failure: true
steps:
- uses: actions/checkout@v2
with:
node-version: 12.x
- name: install dependencies
run: yarn install
- name: test
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
- run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
working-directory: test-app
31 changes: 12 additions & 19 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
# See https://help.github.com/ignore-files/ for more about ignoring files.
# The authoritative copies of these live in the monorepo root (because they're
# more useful on github that way), but the build copies them into here so they
# will also appear in published NPM packages.
/README.md
/LICENSE.md

# compiled output
/dist
/tmp
dist/
declarations/

# dependencies
/node_modules
/bower_components
# npm/pnpm/yarn pack output
*.tgz

# misc
/.sass-cache
/connect.lock
/coverage/*
/libpeerconnection.log
# deps & caches
node_modules/
.eslintcache
npm-debug.log*
yarn-error.log
testem.log

# ember-try
.node_modules.ember-try/
bower.json.ember-try
package.json.ember-try
.prettiercache
35 changes: 0 additions & 35 deletions .npmignore

This file was deleted.

Loading
Loading