Skip to content

Commit

Permalink
Drop support for IE 11
Browse files Browse the repository at this point in the history
  • Loading branch information
bertdeblock authored and knownasilya committed Aug 16, 2023
1 parent e579b03 commit a1995e6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 35 deletions.
6 changes: 1 addition & 5 deletions addon/src/services/page-title.js
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,11 @@ export default class PageTitleService extends Service {
/**
* Find token by id
*
* IE11 compatible approach due to lack of Array.find support
*
* @param {String} id
* @private
*/
_findTokenById(id) {
return this.tokens.filter((token) => {
return token.id === id;
})[0];
return this.tokens.find((token) => token.id === id);
}

updateFastbootTitle(toBeTitle) {
Expand Down
15 changes: 0 additions & 15 deletions docs/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,6 @@ const browsers = [
'last 1 Safari versions',
];

// Ember's browser support policy is changing, and IE11 support will end in
// v4.0 onwards.
//
// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
//
// If you need IE11 support on a version of Ember that still offers support
// for it, uncomment the code block below.

const isCI = Boolean(process.env.CI);
const isProduction = process.env.EMBER_ENV === 'production';

if (isCI || isProduction) {
browsers.push('ie 11');
}

module.exports = {
browsers,
node: 'current', // This is here to avoid "SyntaxError: Unexpected token '.'" from fastboot ember-app.js
Expand Down
15 changes: 0 additions & 15 deletions test-app/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,6 @@ const browsers = [
'last 1 Safari versions',
];

// Ember's browser support policy is changing, and IE11 support will end in
// v4.0 onwards.
//
// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
//
// If you need IE11 support on a version of Ember that still offers support
// for it, uncomment the code block below.

const isCI = Boolean(process.env.CI);
const isProduction = process.env.EMBER_ENV === 'production';

if (isCI || isProduction) {
browsers.push('ie 11');
}

module.exports = {
browsers,
node: 'current', // This is here to avoid "SyntaxError: Unexpected token '.'" from fastboot ember-app.js
Expand Down

0 comments on commit a1995e6

Please sign in to comment.