Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide global require from webpack #978

Merged
merged 2 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions addon/addon/index.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
/* globals requirejs, require */

import { dasherize, classify, underscore } from './string';
import classFactory from './utils/class-factory';

if (typeof requirejs.entries === 'undefined') {
requirejs.entries = requirejs._eak_seen;
if (typeof globalThis.requirejs.entries === 'undefined') {
globalThis.requirejs.entries = globalThis.requirejs._eak_seen;
}

export class ModuleRegistry {
constructor(entries) {
this._entries = entries || requirejs.entries;
this._entries = entries || globalThis.requirejs.entries;
}
moduleNames() {
return Object.keys(this._entries);
Expand All @@ -18,7 +16,7 @@ export class ModuleRegistry {
return moduleName in this._entries;
}
get(...args) {
return require(...args);
return globalThis.require(...args);
}
}

Expand Down
6 changes: 4 additions & 2 deletions addon/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { Resolver as ResolverContract } from "@ember/owner";
import EmberObject from "@ember/object";
export default class Resolver extends EmberObject {}

export default class Resolver {
static create(props: Record<string, unknown>): InstanceType<this>;
}
export default interface Resolver extends Required<ResolverContract> {
pluralizedTypes: Record<string, string>;
}
Loading