-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to V2 format #346
Convert to V2 format #346
Conversation
so test-app/tests doesn't look so weird
They will live only at the top level.
This is a complete example now. There are some further enhancements I have coming down the pipe to make the DX more familiar. The big one is adding a build step that takes care of template inlining so that the authored addon code can use normal template colocation, while the published code will be explicit. |
Now this has its own small & fast build pipeline based on rollup. It takes care of template-colocation, and it generates your appTree for you, so you don't need to keep all those reexport-only files around. |
I'm going to merge this to make it easier to iterate on. Happy to take feedback and get some consensus before cutting a release. |
This converts to embroider v2 format, as one of our first examples of how to do that. The plan would be to land this and a few others and then extract the learned best-practices into an actual blueprint.
@embroider/addon-shim
we depend onoutput
from scenario-tester to gitignore