Merge pull request #738 from bmish/set-not-array

Use sets instead of arrays for better performance

lib/rules/classic-decorator-no-classic-methods.js

@@ -1,4 +1,4 @@
-const disallowedMethods = [
+const disallowedMethods = new Set([
   'get',
   'set',
   'getProperties',
@@ -12,7 +12,7 @@ const disallowedMethods = [
   'notifyPropertyChange',
   'cacheFor',
   'proto',
-];
+]);
 
 function disallowedMethodErrorMessage(name) {
   return `The this.${name}() method is a classic ember object method, and can't be used in octane classes. You can refactor this usage to use a utility version instead (e.g. get(this, 'foo')), or to use native/modern syntax instead. Alternatively, you can add the @classic decorator to this class to continue using classic APIs.`;
@@ -61,7 +61,7 @@ module.exports = {
           return;
         }
 
-        if (disallowedMethods.includes(node.property.name)) {
+        if (disallowedMethods.has(node.property.name)) {
           context.report({
             node,
             message: disallowedMethodErrorMessage(node.property.name),

lib/rules/named-functions-in-promises.js

@@ -63,11 +63,11 @@ module.exports = {
 
 function hasPromiseExpression(node) {
   const callee = node.callee;
-  const promisesMethods = ['then', 'catch', 'finally'];
+  const promisesMethods = new Set(['then', 'catch', 'finally']);
 
   return (
     types.isCallExpression(callee.object) &&
     types.isIdentifier(callee.property) &&
-    promisesMethods.includes(callee.property.name)
+    promisesMethods.has(callee.property.name)
   );
 }

lib/rules/no-function-prototype-extensions.js

@@ -23,12 +23,15 @@ module.exports = {
   create(context) {
     const message = "Don't use Ember's function prototype extensions";
 
-    const functionPrototypeExtensionNames = ['property', 'observes', 'observesBefore', 'on'];
+    const functionPrototypeExtensionNames = new Set([
+      'property',
+      'observes',
+      'observesBefore',
+      'on',
+    ]);
 
     const isFunctionPrototypeExtension = function(property) {
-      return (
-        types.isIdentifier(property) && functionPrototypeExtensionNames.includes(property.name)
-      );
+      return types.isIdentifier(property) && functionPrototypeExtensionNames.has(property.name);
     };
 
     const report = function(node) {

lib/rules/no-global-jquery.js

@@ -35,13 +35,13 @@ module.exports = {
 
     return {
       ImportDeclaration(node) {
-        const validImportAlias = ['ember', 'jquery'];
+        const validImportAlias = new Set(['ember', 'jquery']);
         // Track if the 'jquery' and/or 'ember' module (if an application
         // is not using the new modules import syntax) is being imported.
         // Will exclude non-ember or non-jquery imports such as:
         //    - `import Foo from 'bar';`
         //    - `import { readOnly } from '@ember/object/computed';`
-        if (validImportAlias.includes(node.source.value)) {
+        if (validImportAlias.has(node.source.value)) {
           const isJqueryImport = node.source.value === 'jquery';
           if (isJqueryImport) {
             hasJqueryImport = true;

lib/rules/no-on-calls-in-components.js

@@ -24,7 +24,7 @@ module.exports = {
 
   create(context) {
     const message = "Don't use .on() for component lifecycle events.";
-    const lifecycleHooks = [
+    const lifecycleHooks = new Set([
       'init',
       'didUpdateAttrs',
       'didReceiveAttrs',
@@ -36,7 +36,7 @@ module.exports = {
       'willDestroyElement',
       'willClearRender',
       'didDestroyElement',
-    ];
+    ]);
 
     const isOnCall = function(node) {
       if (!node.value) {
@@ -48,7 +48,7 @@ module.exports = {
 
       return (
         types.isCallExpression(value) &&
-        lifecycleHooks.includes(args[0]) &&
+        lifecycleHooks.has(args[0]) &&
         ((types.isIdentifier(callee) && callee.name === 'on') ||
           (types.isMemberExpression(callee) &&
             types.isIdentifier(callee.object) &&

lib/rules/use-ember-get-and-set.js

@@ -86,7 +86,7 @@ module.exports = {
 
     const avoidedMethods = ['get', 'set', 'getProperties', 'setProperties', 'getWithDefault'];
 
-    const testMethodsToSkip = ['get', 'set'];
+    const testMethodsToSkip = new Set(['get', 'set']);
 
     const directoriesToSkipCompletely = ['mirage'];
 
@@ -124,7 +124,7 @@ module.exports = {
           isFileInDirectory('tests') &&
           isThisExpression(callee.object) &&
           isIdentifier(method) &&
-          testMethodsToSkip.includes(method.name)
+          testMethodsToSkip.has(method.name)
         ) {
           return;
         }

lib/utils/ember.js

@@ -249,12 +249,12 @@ function isObserverProp(node) {
 }
 
 function isComputedProp(node) {
-  const allowedMemberExpNames = ['volatile', 'readOnly', 'property', 'meta'];
+  const allowedMemberExpNames = new Set(['volatile', 'readOnly', 'property', 'meta']);
   if (types.isMemberExpression(node.callee) && types.isCallExpression(node.callee.object)) {
     return (
       isModule(node.callee.object, 'computed') &&
       types.isIdentifier(node.callee.property) &&
-      allowedMemberExpNames.includes(node.callee.property.name)
+      allowedMemberExpNames.has(node.callee.property.name)
     );
   }
   return isModule(node, 'computed');

lib/utils/new-module.js

@@ -2,7 +2,7 @@
 
 const { isIdentifier, isObjectPattern, isVariableDeclarator } = require('./types');
 
-const EMBER_NAMESPACES = ['inject.controller', 'inject.service'];
+const EMBER_NAMESPACES = new Set(['inject.controller', 'inject.service']);
 
 // Both the Controller module and Service module each make available the
 // "inject" namespace. In order to make it more readable, so it's more
@@ -11,7 +11,7 @@ const EMBER_NAMESPACES = ['inject.controller', 'inject.service'];
 // can properly populate the import specifier to report the ESLint error.
 // Ex: import { inject as service } from '@ember/service';
 function isNamespace(obj) {
-  return EMBER_NAMESPACES.includes(`${obj.parent}.${obj.key}`);
+  return EMBER_NAMESPACES.has(`${obj.parent}.${obj.key}`);
 }
 
 function isNamedExport(obj) {