fix: tweak autofix for require-super-in-init rule

ember-cli · Sep 25, 2020 · fed94c4 · fed94c4
1 parent b4157c8
commit fed94c4
Show file tree

Hide file tree

Showing 2 changed files with 102 additions and 81 deletions.
diff --git a/lib/rules/require-super-in-init.js b/lib/rules/require-super-in-init.js
@@ -96,15 +96,10 @@ module.exports = {
           const replacement = isNativeClass
             ? `super.${lifecycleHookName}(...arguments);`
             : 'this._super(...arguments);';
-          if (node.value.body.body.length > 0) {
-            // Function has at least one statement in it so just insert before that.
-            return fixer.insertTextBefore(node.value.body.body[0], `${replacement}\n`);
-          } else {
-            // Function is empty so insert after curly brace.
-            const sourceCode = context.getSourceCode();
-            const startOfBlockStatement = sourceCode.getFirstToken(node.value.body);
-            return fixer.insertTextAfter(startOfBlockStatement, replacement);
-          }
+          // Insert right after function curly brace.
+          const sourceCode = context.getSourceCode();
+          const startOfBlockStatement = sourceCode.getFirstToken(node.value.body);
+          return fixer.insertTextAfter(startOfBlockStatement, `\n${replacement}`);
         },
       });
     }