Add new rule no-array-prototype-extensions
#1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
requested changes
Apr 5, 2022
|
Thanks for starting on this! I've been wanting to see this rule for a long time. |
bmish
reviewed
Apr 6, 2022
bmish
requested changes
Apr 6, 2022
|
This is looking pretty good. One tip is to try running this on a real codebase to ensure it works properly and doesn't crash. |
Closed
|
Another note is that this looks like a candidate to be enabled as a |
bmish
reviewed
Apr 6, 2022
added 2 commits
April 7, 2022 19:54
bmish
changed the title
no-array-prototype-extensionsno-array-prototype-extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1075
Fixes #922
RFC to be added.
Tests
Test Suites: 107 passed, 107 total
Tests: 3042 passed, 3042 total
Snapshots: 1 passed, 1 total
Time: 20.315 s, estimated 29 s
Ran all test suites.
✨ Done in 21.61s.