Add template block comment eslint directives #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
add-block-comment
branch
from
e329f03
to
fa12979
Compare
patricklx
changed the title
patricklx
changed the title
lib/parsers/gjs-gts-parser.js
Outdated
| const idx = parentBody.indexOf(comment); | ||
| parentBody.splice(idx, 1); | ||
| // comment type can be a block comment or a line comment | ||
| // block comments start with <!--- or {{!--, line comments with <!-- or {{! |
There was a problem hiding this comment.
{{!}} Are also block comments
There was a problem hiding this comment.
how so? {{! only comments out 1 line. edit: ah it can also do multine, right. anyway, just need 2 different syntaxes
i just need to distinguish it because eslint handles those differently.
html comments has issues... glimmerjs/glimmer-vm#1487
There was a problem hiding this comment.
html comments has issues
Yeah, i saw that. Mourd be good to fix.
I'm almost done with getting the upgrade in ember figured out
There was a problem hiding this comment.
btw,
<!---
multi line
--->did not make it into the output
lib/parsers/gjs-gts-parser.js
Outdated
| parentBody.splice(idx, 1); | ||
| // comment type can be a block comment or a line comment | ||
| // block comments start with <!--- or {{!--, line comments with <!-- or {{! | ||
| comment.type = /^({{!--|<!---)/.test(code.slice(...comment.range)) ? 'Block' : 'Line'; |
There was a problem hiding this comment.
Suggested change
| comment.type = /^({{!--|<!---)/.test(code.slice(...comment.range)) ? 'Block' : 'Line'; | |
| comment.type = /^({{!|<!--)/.test(code.slice(...comment.range)) ? 'Block' : 'Line'; |
There was a problem hiding this comment.
i found out that block comment works for eslint in all cases
patricklx
force-pushed
the
add-block-comment
branch
from
34d65d5
to
1824b52
Compare
patricklx
force-pushed
the
add-block-comment
branch
from
1824b52
to
1a261e2
Compare
NullVoxPopuli
approved these changes
Nov 2, 2023
bmish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.