-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gjs/gts parser] fix references for tags with a dot & non standard html tags #1992
Conversation
@@ -260,6 +261,34 @@ function preprocessGlimmerTemplates(info, code) { | |||
n.loc.start = codeLines.offsetToPosition(tpl.templateRange[0]); | |||
n.loc.end = codeLines.offsetToPosition(tpl.templateRange[1]); | |||
} | |||
// split up element node into sub nodes to be able to reference tag name | |||
// parts <Foo.Bar /> -> nodes for `Foo` and `Bar` | |||
if (n.type === 'ElementNode') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be @glimmer/syntax responsibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it should, yes.
same for block params, there is no node for them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, can you open an issue over on glimmer-vm?
Once we get that shipped, we can clean up here
@patricklx let's mention "gjs/gts parser" in the title of these PRs so users have the relevant context to understand which part of eslint-plugin-ember these PRs are affecting. |
fixes #1991