Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ember-data rule: require-async-inverse-relationship #2155

Conversation

wozny1989
Copy link
Contributor

@wozny1989
Copy link
Contributor Author

@NullVoxPopuli What do you think about this?

@NullVoxPopuli
Copy link
Contributor

Adding new recommended rules is a breaking change -- this new rule would have to be left out of the recommended set until the next major of eslint-plugin-ember.

As for the lint rule itself -- I'll let @runspired speak to that.

Code seems 👍

@wozny1989 wozny1989 force-pushed the ember-data-require-async-inverse-relationship branch from 3221491 to b3f6eb4 Compare July 8, 2024 19:31
@runspired
Copy link

@NullVoxPopuli unclear to me on breaking changes when its a lint to support something that was deprecated and removed a full major version ago in EmberData itself.

That said: @wozny1989 think you could PR this to EmberData instead? we have the infra for a rules package we intended to start adding rules to (including this one) here https://github.com/emberjs/data/tree/main/packages/eslint-plugin-ember-data

@bmish
Copy link
Member

bmish commented Jul 8, 2024

The rule can be made recommended later but not when it's initially added, as mentioned here: https://github.com/ember-cli/eslint-plugin-ember#creating-a-new-rule

Note that new rules should not immediately be added to the recommended configuration, as we only consider such breaking changes during major version updates.

@bmish bmish added Enhancement New Rule Idea for a new lint rule labels Jul 8, 2024
@wozny1989 wozny1989 force-pushed the ember-data-require-async-inverse-relationship branch from b3f6eb4 to 8ee3400 Compare July 9, 2024 07:32
@wozny1989 wozny1989 changed the title Add new recommended ember-data rule: require-async-inverse-relationship Add new ember-data rule: require-async-inverse-relationship Jul 9, 2024
@wozny1989
Copy link
Contributor Author

@bmish Sorry, I didn't notice thing about recommendation, just pushed changes and fix lint errors on CI

@wozny1989 wozny1989 force-pushed the ember-data-require-async-inverse-relationship branch from 8ee3400 to 9a77650 Compare July 9, 2024 17:28
@wozny1989 wozny1989 force-pushed the ember-data-require-async-inverse-relationship branch from 9a77650 to c1983b0 Compare July 9, 2024 17:36
@bmish
Copy link
Member

bmish commented Jul 30, 2024

Are we good to go with this? I don't mind having Ember Data rules in this plugin for now as we already have a couple and this plugin is widely used.

@bmish bmish merged commit af62351 into ember-cli:master Aug 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New Rule Idea for a new lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting Ember Data relationship inverses
4 participants