New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass `...arguments` in autofix for attrs hooks in `require-super-in-init` rule #962

Merged

bmish merged 1 commit into ember-cli:master from bmish:require-super-in-init-fix-attrs

Sep 27, 2020

Member

bmish commented Sep 27, 2020 •

edited

Loading

attrs hooks (didReceiveAttrs, didUpdateAttrs) should call super without ...arguments to satisfy the ember/no-attrs-snapshot rule.

Note that this autofix only applies when the checkInitOnly option of the ember/require-super-in-init option is disabled.


          fix: do not pass ...arguments in autofix for attrs hooks in require-s…

65d1081

…uper-in-init rule

bmish added the bug label

bmish merged commit 06282c4 into ember-cli:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug