Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{{this.foo}}} is converted into {{this.foo}} #64

Closed
GavinJoyce opened this issue Jun 21, 2019 · 4 comments · Fixed by glimmerjs/glimmer-vm#949 or #76
Closed

{{{this.foo}}} is converted into {{this.foo}} #64

GavinJoyce opened this issue Jun 21, 2019 · 4 comments · Fixed by glimmerjs/glimmer-vm#949 or #76

Comments

@GavinJoyce
Copy link
Collaborator

It seems that glimmer's printer might be doing this:

https://astexplorer.net/#/gist/bef864eb53e6e4666a34d9b8cc16dfa2/ae0aae9f2891948f24a7c34b9caa4456f882faf9

The AST is correct, the rendered output isn't:

Screen Shot 2019-06-21 at 13 54 55

@tylerturdenpants
Copy link
Collaborator

I’m on mobile... but should we fix this until glimmer does? @GavinJoyce

@GavinJoyce
Copy link
Collaborator Author

I believe that @paddyobrien is going to have a go at fixing it in glimmer

@GavinJoyce
Copy link
Collaborator Author

we'll need to upgrade glimmer before closing this

@GavinJoyce GavinJoyce reopened this Jun 25, 2019
@tylerturdenpants
Copy link
Collaborator

i'm in the process of doing that chore work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants