Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print unescaped statements correctly #949

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Print unescaped statements correctly #949

merged 1 commit into from
Jun 25, 2019

Conversation

paddyobrien
Copy link

Fixes https://github.com/rajasegar/ember-angle-brackets-codemod/issues/64

While working on migrating a codebase to angle brackets I discovered that {{{foo}}} gets converted to {{foo}}.

@paddyobrien paddyobrien changed the title Print escaped statements correctly Print unescaped statements correctly Jun 21, 2019
Turbo87
Turbo87 approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thanks!

@Turbo87 Turbo87 added the bug label Jun 25, 2019
@rwjblue rwjblue merged commit a232b98 into glimmerjs:master Jun 25, 2019
@GavinJoyce GavinJoyce mentioned this pull request Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@Turbo87 Turbo87 Turbo87 approved these changes

@lifeart lifeart lifeart approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{{{this.foo}}} is converted into {{this.foo}}
4 participants
@paddyobrien @rwjblue @Turbo87 @lifeart