Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor other addon's content-for hooks. #14

Merged
merged 2 commits into from
Apr 8, 2015
Merged

Honor other addon's content-for hooks. #14

merged 2 commits into from
Apr 8, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 8, 2015

Supercedes #13.

@rwjblue rwjblue mentioned this pull request Apr 8, 2015
Closed
rwjblue added a commit that referenced this pull request Apr 8, 2015
@rwjblue
Merge pull request #14 from rwjblue/use-content-for
78b79e6 
Honor other addon's content-for hooks.
@rwjblue rwjblue merged commit 78b79e6 into ember-fastboot:master Apr 8, 2015
@rwjblue rwjblue deleted the use-content-for branch April 8, 2015 15:52
@gpoitch
Copy link
Contributor

gpoitch commented Apr 8, 2015

@rwjblue 👍 thanks!
Note that this still first looks for 'app/fastboot.html' in it's raw unbuilt form, if it exists. (I wasn't sure the use case for it, so I left it as-is). So you'll still have to strip the content-for blocks out of there.

xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this pull request Nov 16, 2020
@danmcclain
1.0.0-rc.4 (ember-fastboot#14)
3025dc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @gpoitch