Added source-map-support library which helps with stack traces. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library needs some assistance to attach to `Error.prepareStackTrace` outside the VM then again inside the VM. Internally it keeps track of a `errorFormatterInstalled` flag - this flag stops any future calls to install on `Error.prepareStackTrace` after the first one, which is usually the one outside the VM.
jmurphyau
force-pushed
the
source-map-support
branch
from
5d5d7b2 to
c8c7d53
Compare
|
Before: After: |
|
Looks awesome! |
|
@tomdale have you had a chance to look into this one? |
|
@jmurphyau Hey! I just saw it today, unfortunately—somehow I was not watching this repo and not getting any emails. I'll take a look. Sorry for the delay! |
tomdale
added a commit
that referenced
this pull request
Feb 23, 2016
Added source-map-support library which helps with stack traces.
bantic
pushed a commit
to bantic/ember-fastboot-server
that referenced
this pull request
Apr 28, 2016
Use separate output path for `ember fastboot`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library needs some assistance to attach to
Error.prepareStackTraceoutside the VM then again inside the VM. Internally it keeps track of aerrorFormatterInstalledflag - this flag stops any future calls to install onError.prepareStackTraceafter the first one, which is usually the one outside the VM.