Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1387 enforce data diff #1388

Merged

Conversation

BrianDouglasIE
Copy link
Contributor

@BrianDouglasIE BrianDouglasIE commented Jul 23, 2024

fixes 1387

Couldn't see this as a check in remark, if exists I can add.

markdownlint

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit 7b6e751
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/66a0c5f6d5df72000885cd58
😎 Deploy Preview https://deploy-preview-1388--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great :)

@mansona mansona force-pushed the feature/1387-enforce-data-diff branch from c80f914 to c45e77c Compare July 23, 2024 11:47
@mansona
Copy link
Member

mansona commented Jul 23, 2024

this is now failing correctly 🎉

@mansona mansona force-pushed the feature/1387-enforce-data-diff branch from c45e77c to 26cd26b Compare July 23, 2024 12:01
@MinThaMie MinThaMie merged commit 8917059 into ember-learn:main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint: disallow diff as code fence language in favour of syntax highlighting diffs
3 participants