doing error transition in the redirect hook when class isn't found #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddjordan
changed the title
toddjordan
force-pushed
the
route-error-handling
branch
from
8aff7c3 to
da4f8c2
Compare
transition to 404 error page from redirect instead of modal hook
toddjordan
force-pushed
the
route-error-handling
branch
from
da4f8c2 to
8c77fce
Compare
toddjordan
changed the title
toddjordan
commented
Jul 9, 2017
| @@ -25,20 +25,27 @@ export default Ember.Route.extend(ScrollTracker, { | |||
| find(typeName, param) { | |||
| return this.store.find(typeName, param).catch(() => { | |||
| return this.store.find('namespace', param).catch(() => { | |||
| return this.transitionTo('project-version'); // class doesn't exist in new version | |||
| return Ember.RSVP.resolve({ isError: true }); | |||
There was a problem hiding this comment.
So fastboot gives back a 500 when you transition during the model hook or afterModel hook, so I need to communicate to the redirect hook that I want to send this to our 404 page.
toddjordan
commented
Jul 9, 2017
| @@ -0,0 +1,10 @@ | |||
| <article class="whoops"> | |||
There was a problem hiding this comment.
Using the same template as error.hbs (without the logic). Open to some design love.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per ember-fastboot/ember-cli-fastboot#202
see #186