Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covered RFCs 549 and 554 (Ember Times 124) #348

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Covered RFCs 549 and 554 (Ember Times 124) #348

merged 2 commits into from
Nov 15, 2019

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Nov 14, 2019

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Nov 14, 2019
jayjayjpg
jayjayjpg approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I didn't know about ?? before, so thank you again for teaching me another new thing with this ✨ writeup!

@jayjayjpg jayjayjpg merged commit 5897531 into ember-learn:blog/embertimes-124 Nov 15, 2019
@ijlee2
Copy link
Member Author

ijlee2 commented Nov 15, 2019

Thanks! I didn't know about ?? either until I read the RFC. It's one of the reasons I love writing for the Times!

@ijlee2 ijlee2 deleted the il-11142019 branch November 15, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijlee2 @jayjayjpg