Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write up on Ember CLI improvement tips #591

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Write up on Ember CLI improvement tips #591

merged 3 commits into from
Apr 2, 2020

Conversation

abhilashlr
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Apr 1, 2020
@amyrlam amyrlam requested a review from a team April 1, 2020 01:51
amyrlam
amyrlam approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, thanks for your help this week!

made some suggestions, my reasoning was that it's a gist and not an article per se

source/2020-04-03-the-ember-times-issue-142.md Outdated Show resolved Hide resolved
@abhilashlr @amyrlam
Update source/2020-04-03-the-ember-times-issue-142.md
bcfbd8f 
Co-Authored-By: Amy Lam <amy.lam@betterup.co>
@abhilashlr
Copy link
Member Author

👍 looks good, thanks for your help this week!

made some suggestions, my reasoning was that it's a gist and not an article per se

Done @amyrlam

chrisrng
chrisrng reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@chrisrng chrisrng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes in wording but lgtm thank you!

source/2020-04-03-the-ember-times-issue-142.md Outdated Show resolved Hide resolved
@abhilashlr @chrisrng
Update source/2020-04-03-the-ember-times-issue-142.md
ac8744b 
Co-Authored-By: Chris Ng <chrisrng@users.noreply.github.com>
jayjayjpg
jayjayjpg approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! Thank you for another ✨ writeup for the Ember Times!

@jayjayjpg jayjayjpg merged commit 9388c4c into ember-learn:blog/embertimes-142 Apr 2, 2020
@abhilashlr abhilashlr deleted the patch-2 branch April 3, 2020 14:24
@abhilashlr
Copy link
Member Author

This reads great! Thank you for another ✨ writeup for the Ember Times!

Thanks to you, @amyrlam and @chrisrng 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrng chrisrng chrisrng left review comments

@jayjayjpg jayjayjpg jayjayjpg approved these changes

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhilashlr @amyrlam @chrisrng @jayjayjpg