Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Glimmer 2 Betas #594

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Adds Glimmer 2 Betas #594

merged 4 commits into from
Apr 3, 2020

Conversation

jaredgalanis
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Apr 3, 2020
rwjblue
rwjblue reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for working on this!

Only had one small suggestion inline...

source/2020-04-03-the-ember-times-issue-142.md Outdated Show resolved Hide resolved
ijlee2
ijlee2 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple of suggestions. Looks good overall!

jaredgalanis and others added 3 commits April 3, 2020 09:19
@jaredgalanis @ijlee2
Update source/2020-04-03-the-ember-times-issue-142.md
357b3df 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis @ijlee2
Update source/2020-04-03-the-ember-times-issue-142.md
38d1c49 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis
update std build section and a few other polishes
0d40f93
@jaredgalanis jaredgalanis merged commit 9b6ee66 into blog/embertimes-142 Apr 3, 2020
@jaredgalanis jaredgalanis deleted the glimmer-2-beta branch April 3, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredgalanis @rwjblue @ijlee2