ember-new-plus (for The Ember Times - Issue No. 153) #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
reviewed
Jun 17, 2020
ijlee2
reviewed
Jun 17, 2020
ijlee2
reviewed
Jun 17, 2020
ijlee2
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Aseem, thanks so much for sharing your news with us (and your script to set up many DX-related tools for Ember apps)!
I left a few suggestions that I think will improve the writing. I'll go ahead and approve this PR so that you can make changes and merge your PR at any time.
|
I pushed a commit to fix merge conflict with Matthew's PR. |
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
|
Thanks, Isaac, for taking the time to suggest the changes. I've incorporated them in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the
ember-new-plussection in The Ember Times - Issue No. 153