Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New flashy benchmark for comparing vanilla/native JS to ember and glimmer components:" #827

Conversation

hergaiety
Copy link
Contributor

Writes up "New flashy benchmark for comparing vanilla/native JS to ember and glimmer components:"
https://twitter.com/nullvoxpopuli/status/1335616011744251907

I only took a guess at the image path based on some other things I see in this repo, but I'm not confident it'll work. Can someone confirm?

@amyrlam amyrlam requested a review from a team December 8, 2020 04:38
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! 🙇‍♀️

Can you add your name to the bottom where it says the crowd?

<add blurb and emoji to "SOME-INTRO-HERE">
Play with [the interactive browser demo](https://nullvoxpopuli.github.io/ember-three-boxes-demo/) or [explore the source](https://github.com/NullVoxPopuli/ember-three-boxes-demo) behind a performance comparison of Native JS, Ember Components and Glimmer Components. Feel the performance improvements the core team has achieved for yourself! 🔥

![Glimmer rendering thousands of three.js elements with fast performance](/images/blog/emberjstimes/nullvoxpopuli-glimmer-performance.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work! If we need to tweak the placement / alignment or something, we can always change it to HTML upstream, something like this:

<div class="float-right padded portrait-frame"><img alt="Serena Fritsch" title="Serena Fritsch - Contributor to Ember" src="/images/blog/emberjstimes/serenaf.jpeg" /></div>

source/2020-12-18-the-ember-times-issue-170.md Outdated Show resolved Hide resolved
hergaiety and others added 2 commits December 8, 2020 08:15
@hergaiety
Copy link
Contributor Author

@amyrlam suggestions addressed :)

@hergaiety hergaiety merged commit da24de2 into ember-learn:blog/embertimes-170 Dec 8, 2020
@hergaiety hergaiety deleted the gaiety-benchmark-comparison branch December 8, 2020 16:12
@amyrlam
Copy link
Member

amyrlam commented Dec 9, 2020

@hergaiety thanks! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants