Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Qonto Mirage writeup #927

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Add Qonto Mirage writeup #927

merged 3 commits into from
Mar 12, 2021

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Mar 11, 2021

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 11, 2021
@amyrlam amyrlam changed the title Add Qonto writeup Add Qonto Mirage writeup Mar 11, 2021
@amyrlam amyrlam requested a review from a team March 11, 2021 21:19
ijlee2
ijlee2 reviewed Mar 12, 2021
View reviewed changes
content/the-ember-times-issue-175.md Outdated
@@ -58,14 +61,11 @@ To learn more how `ember-responsive-image` can help you optimize loading images,

---

## [4. Section title in sentence case 🐹](section-url)
## [Blog post: How Qonto used Mirage JS for complex user flow testing ⬆️](https://medium.com/qonto-way/how-to-handle-uploading-and-parsing-files-in-your-frontend-app-tests-19bee8e7a61f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check, did you mean to include the words blog post in front?

ijlee2
ijlee2 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the awesome write-up!

amyrlam and others added 2 commits March 12, 2021 10:17
@amyrlam @ijlee2
Update content/the-ember-times-issue-175.md
72cde40 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@amyrlam
Update the-ember-times-issue-175.md
f5970dd
@amyrlam
Copy link
Member Author

amyrlam commented Mar 12, 2021

i fixed it, but had some github unicorns so comments never posted. thanks - merging in!

@amyrlam amyrlam merged commit 23782f0 into blog/embertimes-175 Mar 12, 2021
@amyrlam amyrlam deleted the amy/embertimes-175 branch March 12, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyrlam @ijlee2