Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify TypeScript RFC comments in Ember Times 175 #933

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Clarify TypeScript RFC comments in Ember Times 175 #933

merged 2 commits into from
Mar 13, 2021

Conversation

chriskrycho
Copy link
Contributor

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

As requested, clarifies what the Official TypeScript Support RFC does and doesn't do!

Related Issue(s)

N/A

Sources

N/A

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 13, 2021
@chriskrycho chriskrycho mentioned this pull request Mar 13, 2021
Merged
16 tasks
@amyrlam amyrlam self-requested a review March 13, 2021 03:45
amyrlam
amyrlam approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriskrycho thanks for clarifying the copy, much appreciated! appreciate your input and help before publish 💯

@amyrlam amyrlam merged commit a6c4050 into ember-learn:blog/embertimes-175 Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriskrycho @amyrlam