-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the cheat sheet for the Octane launch #19
Conversation
@@ -360,6 +391,45 @@ <h4>Octane</h4> | |||
</div> | |||
</section> | |||
|
|||
<section aria-labelledby="section-default-args"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is just moved from its previous (incorrect) location under Templates
<MyComponent @answer=42 /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be @answer={{42}}
, right? at least that's what is suggested in ember-template-lint
:
Attribute [attribute] should be either quoted or wrapped in mustaches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
Also: @action
helloWorld() {
console.log('Hello, world!');
}
@action
saySomethingElse(message) {
console.log(message);
} these don't need the |
@MarcoUmpierrez it's generally best practice to mark methods used in templates with |
Hello everyone, thank you so much for the reviews! If you can think of anything else that will improve this cheat sheet, let me know :) |
Closes #18
Please let me know if anything is missing or confusing! The best way to review this is to look at the screenshot below or run this app locally.
Changed:
Added
@model