Replace ProgressBar with ember-styleguide components #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for empress-blog-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aoifehannigan
changed the title
aoifehannigan
force-pushed
the
replace-progress-loader
branch
from
3787c47
to
ab290cf
Compare
mansona
force-pushed
the
replace-progress-loader
branch
from
ab290cf
to
de22ed4
Compare
mansona
changed the title
|
Hey @aoifehannigan sorry for taking so long to get back to you on this 🙈 we've been very overwhelmed on the website work recently and we're only just catching up now. It turns out that I did half of what this PR originally did in #117 which ended up being a massive change to get CI passing again (at the time) I rebased your PR for you and the only work that was left was the ProgressBar so It's still useful to merge 🎉 sorry again for taking so long to get to this |
mansona
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Issue #112 replacing the
<ProgressBar />component with<EsProgressBar />. The<Sidebar />component was also replaced with<EsSidebar />as the upgrade to the latest version ofember-styleguideincluded some conflicting styles causing display issues.