Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update finding Record section in ember-data guides to teach request service #2030

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update finding Record section in ember-data guides to teach request service #2030

wants to merge 5 commits into from
+49 −45

Conversation

MehulKChaudhari
Copy link

@MehulKChaudhari MehulKChaudhari commented May 31, 2024 •
edited
Loading

This is to make changes to this page

this are changes related to ember-data request service paradigm RFC

@netlify Netlify
Copy link

netlify bot commented May 31, 2024 •
edited
Loading

✅ Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit 10ab3aa
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/67869f5c9ea3fa0008c3862c
😎 Deploy Preview https://deploy-preview-2030--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Baltazore
Baltazore reviewed Jun 18, 2024
View reviewed changes
Copy link

@Baltazore Baltazore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall, still have some questions to resolve.

guides/release/models/finding-records.md Outdated Show resolved Hide resolved
guides/release/models/finding-records.md Show resolved Hide resolved
guides/release/models/finding-records.md Show resolved Hide resolved
guides/release/models/finding-records.md Show resolved Hide resolved
@MehulKChaudhari MehulKChaudhari marked this pull request as ready for review August 9, 2024 16:47
Baltazore
Baltazore reviewed Jan 14, 2025
View reviewed changes
Copy link

@Baltazore Baltazore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code parts looks correct, added minor change requests for consistency.

someone please review is linguistically all sounds good

guides/release/models/finding-records.md Outdated Show resolved Hide resolved
guides/release/models/finding-records.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baltazore Baltazore Baltazore left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MehulKChaudhari @Baltazore