-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic linters for project #13
Comments
Completely support this! And I think it makes sense to use the same linter as ember-cli. |
@kennethlarsen Should we default to prettier style for linting? Here's what I had in mind:
|
I’d vote for doing the setup I describe in emberjs/rfcs#628 😃 |
Agree with Robert! @abhilashlr is that something you can help out with? |
@rwjblue yep, precisely what I meant as well citing few example configurations. I think as mentioned in the RFC, we can restrict to |
@kennethlarsen Sure, I will work on it 👍 |
@kennethlarsen @rwjblue Here you go #22. Let me know if there are some changes that need to be done in the setting up of the rules. |
Since we are just setting up this repo, should we think of linters for all the files that we might have? There are a basic set of linters already in place, it would be nice if we can have rules like standard prettier or airbnb styles in place.
Ember-cli follows:
https://github.com/ember-cli/ember-cli/blob/master/.eslintrc.js
The text was updated successfully, but these errors were encountered: