Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic linters for project #13

Closed
abhilashlr opened this issue Apr 22, 2020 · 7 comments · Fixed by #22
Closed

Basic linters for project #13

abhilashlr opened this issue Apr 22, 2020 · 7 comments · Fixed by #22

Comments

@abhilashlr
Copy link
Member

Since we are just setting up this repo, should we think of linters for all the files that we might have? There are a basic set of linters already in place, it would be nice if we can have rules like standard prettier or airbnb styles in place.

Ember-cli follows:
https://github.com/ember-cli/ember-cli/blob/master/.eslintrc.js

@JennyJudova
Copy link
Contributor

Completely support this! And I think it makes sense to use the same linter as ember-cli.

@abhilashlr
Copy link
Member Author

@kennethlarsen Should we default to prettier style for linting? Here's what I had in mind:

  1. ESLint: prettier with single quotes, semicolons, etc, like below:
    {
      singleQuote: true,
      semi: true,
      bracketSpacing: true,
      endOfLine: 'lf',
      tabs: false,
      tabWidth: 2
    }
    
  2. Stylelint: stylelint-config-standard
  3. Template lint: defaults to octane

@rwjblue
Copy link
Contributor

rwjblue commented May 21, 2020

I’d vote for doing the setup I describe in emberjs/rfcs#628 😃

@kennethlarsen
Copy link
Member

Agree with Robert! @abhilashlr is that something you can help out with?

@abhilashlr
Copy link
Member Author

@rwjblue yep, precisely what I meant as well citing few example configurations. I think as mentioned in the RFC, we can restrict to singleQuote: true.

@abhilashlr
Copy link
Member Author

@kennethlarsen Sure, I will work on it 👍

@abhilashlr
Copy link
Member Author

@kennethlarsen @rwjblue Here you go #22. Let me know if there are some changes that need to be done in the setting up of the rules.
@rwjblue Can you please clarify on the order of the extends array property in .eslintrc.js file as well or does the order not matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants