Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Adds Prettier based on RFC 0628 #22

Merged
merged 3 commits into from
May 22, 2020

Conversation

abhilashlr
Copy link
Member

Fixes #13

@abhilashlr
Copy link
Member Author

@kennethlarsen Please have a look at this too, when you get time :). This PR adds Prettier Linter rules based on Robert's RFC 628.

.eslintrc.js Outdated Show resolved Hide resolved
app/components/cli-update-commands.hbs Outdated Show resolved Hide resolved
app/components/cli-update-commands.hbs Outdated Show resolved Hide resolved
@@ -19,7 +19,7 @@ export const VERSIONS = Object.freeze([
1.7,
1.8,
1.9,
1.10,
1.1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully grok this change, we already have 1.1 listed just above. I think this should still be 1.10.

Copy link
Member Author

@abhilashlr abhilashlr May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a prettier's --fix change 😮 . My bad, didn't realise that we already had a 1.1 and trusted prettier to go ahead with this fix. I will have it corrected. Now I believe, these should be strings in that case. Thoughts?

Copy link
Member Author

@abhilashlr abhilashlr May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That brings up another bug in the implementation that - whichever option we choose between 1.1 or 1.10 (displayed as 1.1) from the version dropdown, there is only 1.1 displayed in the dropdown and the changes corresponding to "from" and "to" versions shows only 1.10's changes. Moving it to a string might solve this problem, although that looks like a fairly bigger change. How do we go about implementing this @rwjblue, could you please help?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I believe, these should be strings in that case

Yeah, probably should be strings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like that is a preexisting issue, can you make an issue to fix it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure I’ll work on it and move them to strings. Thanks 👍🏻

abhilashlr and others added 2 commits May 21, 2020 23:26
Co-authored-by: Robert Jackson <me@rwjblue.com>
@kennethlarsen kennethlarsen merged commit c449e60 into ember-learn:master May 22, 2020
@kennethlarsen
Copy link
Member

Thanks @abhilashlr and thanks @rwjblue for the review ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic linters for project
3 participants