Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli-htmlbars-inline-precompile Caveat #18

Closed
jherdman opened this issue Jun 18, 2018 · 1 comment
Closed

ember-cli-htmlbars-inline-precompile Caveat #18

jherdman opened this issue Jun 18, 2018 · 1 comment

Comments

@jherdman
Copy link
Contributor

I had an integration test I copied from your test suite to debug why my angle bracket component wasn't working:

    this.owner.register('template:components/foo-bar', hbs`hi martin!`);

    await render(hbs`<FooBar />`);

    assert.dom().hasText('hi martin!');

The resultant HTML was:

<foobar></foobar>

I resolved the issue by bumping ember-cli-htmlbars-inline-precompile to ^1.0.3 from ^1.0.0. Perhaps this should be added to the README?

jherdman added a commit to jherdman/ember-angle-bracket-invocation-polyfill that referenced this issue Jun 18, 2018
An extremely lazy solution to ember-polyfills#18.
@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2018

Yes, we should definitely smooth this over. I think we can add that to the README, but I also think we should issue a warning if we detect that the older version is being used.

What do you think?

jherdman added a commit to jherdman/ember-angle-bracket-invocation-polyfill that referenced this issue Jun 19, 2018
jherdman added a commit to jherdman/ember-angle-bracket-invocation-polyfill that referenced this issue Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants