Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Dependency Warning #19

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Additional Dependency Warning #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ know and love, no longer surrounded by mustaches. \o/
ember install ember-angle-bracket-invocation-polyfill
```

You will additionally need to ensure ember-cli-htmlbars-inline-precompile is at least version 1.0.3.

## Usage

The best usage guide is [the RFC itself](https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md),
Expand Down
10 changes: 10 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ module.exports = {
let emberVersion = checker.forEmber();

this.shouldPolyfill = emberVersion.lt('3.4.0-alpha.1');

let parentChecker = new VersionChecker(this.parent);
let precompileVersion = parentChecker.for('ember-cli-htmlbars-inline-precompile');

if (precompileVersion.exists() && precompileVersion.lt('1.0.3')) {
this.ui.writeWarnLine(
'Detected a version of ember-cli-htmlbars-inline-precompile that does not' +
' support angle bracket invocation, please update to at least 1.0.3.'
);
}
},

setupPreprocessorRegistry(type, registry) {
Expand Down