Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-shadowed-elements should allow component names including a dot to start lower case #473

Closed
jelhan opened this issue Aug 15, 2018 · 0 comments
Closed

no-shadowed-elements should allow component names including a dot to start lower case #473

jelhan opened this issue Aug 15, 2018 · 0 comments

Comments

@jelhan
Copy link
Contributor

jelhan commented Aug 15, 2018

Currently this is considered a violation of no-shadowed-elements rule:

<Foo as |s|>
  <s.bar />
</Foo>

If local variable is a hash and therefore component is referred to be dot notation, it can't shadow elements. Therefore the hash should not be enforced to start with an uppercase char IMO.
@jelhan jelhan mentioned this issue Aug 15, 2018
Merged
jelhan added a commit to jelhan/ember-template-lint that referenced this issue Aug 15, 2018
@jelhan
element containing dot should not be considered ambiguous
2ee1e8d 
Before a yielded hash had to start with uppercase char to not violate
no-shadowed-elements rule even so it could not shadow any element cause
having a dot in path.

Fixes ember-template-lint#473
@jelhan jelhan mentioned this issue Aug 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelhan