fix: add deprecation and avoid breaking configs (#9477)

packages/-ember-data/addon-main.cjs

@@ -13,4 +13,19 @@ if (pkg['ember-addon'].version === 1) {
   delete addon.treeForApp;
 }
 
+const included = addon.included;
+addon.included = function includedIntercept() {
+  // we access this as a side-effect to ember-cli will give us a super call
+  const sup = this._super.included;
+  if (this.hasBeenCalled) {
+    return included?.apply(this, arguments);
+  }
+  this.hasBeenCalled = true;
+  const app = this.app;
+  const dirname = app.project.root;
+  const { setConfig } = require('@warp-drive/build-config/cjs-set-config.cjs');
+  setConfig(app, dirname, Object.assign({}, app.options?.emberData, { ___legacy_support: true }));
+  return included?.apply(this, arguments);
+};
+
 module.exports = addon;

packages/build-config/src/cjs-set-config.ts

@@ -0,0 +1 @@
+export { setConfig } from './index.ts';

packages/build-config/src/index.ts

@@ -43,11 +43,36 @@ function recastMacrosConfig(macros: object): MacrosWithGlobalConfig {
 
 export function setConfig(context: object, appRoot: string, config: WarpDriveConfig) {
   const macros = recastMacrosConfig(_MacrosConfig.for(context, appRoot));
+  const isLegacySupport = (config as unknown as { ___legacy_support?: boolean }).___legacy_support;
+  const hasDeprecatedConfig = isLegacySupport && Object.keys(config).length > 1;
+  const hasInitiatedConfig = macros.globalConfig['WarpDrive'];
 
-  if (macros.globalConfig['WarpDrive']) {
+  // setConfig called by user prior to legacy support called
+  if (isLegacySupport && hasInitiatedConfig) {
+    if (hasDeprecatedConfig) {
+      throw new Error(
+        'You have provided a config object to setConfig, but are also using the legacy emberData options key in ember-cli-build. Please remove the emberData key from options.'
+      );
+    }
     return;
   }
 
+  // legacy support called prior to user setConfig
+  if (isLegacySupport && hasDeprecatedConfig) {
+    console.warn(
+      `You are using the legacy emberData key in your ember-cli-build.js file. This key is deprecated and will be removed in the next major version of EmberData/WarpDrive. Please use \`import { setConfig } from '@warp-drive/build-config';\` instead.`
+    );
+  }
+
+  // included hooks run during class initialization of the EmberApp instance
+  // so our hook will run before the user has a chance to call setConfig
+  // else we could print a useful message here
+  // else if (isLegacySupport) {
+  //   console.warn(
+  //     `WarpDrive requires your ember-cli-build file to set a base configuration for the project.\n\nUsage:\n\t\`import { setConfig } from '@warp-drive/build-config';\n\tsetConfig(app, __dirname, {});\``
+  //   );
+  // }
+
   const debugOptions: InternalWarpDriveConfig['debug'] = Object.assign({}, LOGGING, config.debug);
 
   const env = getEnv();

packages/build-config/vite.config-cjs.mjs

@@ -1,13 +1,14 @@
 import { createConfig } from '@warp-drive/internal-config/vite/config.js';
 
-export const externals = ['babel-import-util', 'fs'];
+export const externals = ['babel-import-util', 'fs', 'path'];
 
 export const entryPoints = [
   './cjs-src/transforms/babel-plugin-transform-asserts.js',
   './cjs-src/transforms/babel-plugin-transform-deprecations.js',
   './cjs-src/transforms/babel-plugin-transform-features.js',
   './cjs-src/transforms/babel-plugin-transform-logging.js',
   './cjs-src/addon-shim.js',
+  './src/cjs-set-config.ts',
 ];
 
 export default createConfig(