Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of setupStore/createStore from tests #6357

Closed
3 tasks done
runspired opened this issue Aug 21, 2019 · 2 comments · Fixed by #6448
Closed
3 tasks done

Remove use of setupStore/createStore from tests #6357

runspired opened this issue Aug 21, 2019 · 2 comments · Fixed by #6448
Assignees
@HeroicEric
Labels
🏷️ cleanup This PR primarily removes deprecated functionality 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166

Comments

@runspired
Copy link
Contributor

runspired commented Aug 21, 2019 •
edited
Loading

This is just a tracking issue for

  • removing createStore usage
  • removing setupStore usage
  • eliminating any initializer logic that remains purely for supporting createStore and setupStore

cc @HeroicEric
@runspired runspired added Cleanup 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 labels Aug 21, 2019
@HeroicEric
Copy link
Member

👋

This was referenced Aug 21, 2019
Merged
Closed
HeroicEric added a commit to HeroicEric/data that referenced this issue Aug 28, 2019
@HeroicEric
[CHORE tests] Remove setupStore test helper
6a676b6 
Related to:

- emberjs#6357
- emberjs#6166

This replaces the remaining uses of the `setupStore` helper and removes
the `setupStore` helper itself.
@HeroicEric HeroicEric mentioned this issue Aug 28, 2019
Merged
HeroicEric added a commit to HeroicEric/data that referenced this issue Aug 28, 2019
@HeroicEric
[CHORE tests] Remove setupStore test helper
e9fe3b1 
Related to:

- emberjs#6357
- emberjs#6166

This replaces the remaining uses of the `setupStore` helper and removes
the `setupStore` helper itself.
HeroicEric added a commit to HeroicEric/data that referenced this issue Aug 28, 2019
@HeroicEric
[CHORE tests] Remove setupStore test helper
c2f3c35 
Related to:

- emberjs#6357
- emberjs#6166

This replaces the remaining uses of the `setupStore` helper and removes
the `setupStore` helper itself.
HeroicEric added a commit to HeroicEric/data that referenced this issue Aug 29, 2019
@HeroicEric
[CHORE tests] Remove setupStore test helper
b4989b6 
Related to:

- emberjs#6357
- emberjs#6166

This replaces the remaining uses of the `setupStore` helper and removes
the `setupStore` helper itself.
@rwjblue
Copy link
Member

rwjblue commented Sep 2, 2019

The helper itself is now removed, I think the last thing remaining is determining what of the initializer logic can be killed off now.

@snewcomer snewcomer mentioned this issue Sep 13, 2019
Merged
@runspired runspired added 🏷️ cleanup This PR primarily removes deprecated functionality and removed Cleanup labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeroicEric HeroicEric

Labels
🏷️ cleanup This PR primarily removes deprecated functionality 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CHORE]: eliminate initializer logic not needed after setupStore removed snewcomer/data
3 participants
@rwjblue @HeroicEric @runspired