Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve config handling for polyfillUUID for 4.12+ #8675

Closed
Techn1x opened this issue Jul 6, 2023 · 1 comment
Closed

feat: Improve config handling for polyfillUUID for 4.12+ #8675

Techn1x opened this issue Jul 6, 2023 · 1 comment
Labels
good-first-issue 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance v4-to-v5 Tickets related to v4 to v5 migration paths

Comments

@Techn1x
Copy link

Techn1x commented Jul 6, 2023

Initial discussion was here;
#8664

we should align the config to the others so that we don't have to make folks do this. For all the other configs we just copy-forward into the appropriate packages from the emberData config, including setting up macros configs when needed.

Rather than editing the Readme to indicate how to do the polyfillUUID config correctly, we can instead improve how the config is handled so that it's not necessary.


It was suggested to backport this to 4.12. If it's easy enough, I would also hope it can be backported to 4.8, otherwise there will be folks moving to 4.8 who won't know that they need to install @embroider/macros and @ember-data/store for the polyfillUUID config to work.

@runspired runspired added Bug lts-4-12 Long Term LTS Maintenance labels Jul 12, 2023
@runspired runspired changed the title Improve config handling for polyfillUUID feat: Improve config handling for polyfillUUID for 4.12+ Sep 3, 2023
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Good for New Contributors labels Sep 10, 2023
@runspired runspired added the v4-to-v5 Tickets related to v4 to v5 migration paths label Sep 23, 2023
@jrjohnson
Copy link
Contributor

Using the config:

    '@embroider/macros': {
      setConfig: {
        '@ember-data/store': {
          polyfillUUID: true,
        },
      },
    },

In a brand new pnpm app results in unable to resolve package @ember-data/store.

Steps:

  • ember new pnpm-app --pnpm
  • pnpm install -D @embroider/macros
  • Add config to ember-cli-build.js
  • Run: pnpm run test:ember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance v4-to-v5 Tickets related to v4 to v5 migration paths
Projects
Archived in project
Development

No branches or pull requests

3 participants