Clearer instructions for polyfillUUID #8664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
reviewed
Jul 3, 2023
| activate this polyfill; | ||
| * install `@embroider/macros` if not already installed | ||
| * install `@ember-data/store` if not already installed | ||
| * add this to your ember-cli-build.js file: |
There was a problem hiding this comment.
we should align the config to the others so that we don't have to make folks do this. For all the other configs we just copy-forward into the appropriate packages from the emberData config, including setting up macros configs when needed.
There was a problem hiding this comment.
is that something likely to happen soon? Is it worth not having clear instructions until then?
There was a problem hiding this comment.
Open an issue its something I'll get done for 4.12.x + 5.2+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clearer instructions for polyfillUUID.
The need to install embroider/macros has tripped me up at least 3 times now (When I go to update a repo's ember-data version, I keep forgetting what I did to make it work on a previous repo months prior). Not to mention, the first time I encountered it it took me a long while to figure out why the config entry wasn't doing anything.
Notes for the release