Don't reset sync relationship #5880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes changes the known to be empty behavior. It allows a second get request without an include string will keep any relationship data that the model knows about.
runspired
reviewed
Mar 4, 2019
tests/unit/store/push-test.js
Outdated
| testInDebug( | ||
| 'Calling push with a link for a non async relationship should not reset an existing relationship', | ||
| function(assert) { | ||
| Person.reopen({ |
There was a problem hiding this comment.
could you write a test that
- does not use
reopen - does not use
run
To do this you may need to make the test async. In some cases you may also want to await settled() to ensure relationship state is fully settled post-push, although in this case it should not matter.
This was referenced Mar 4, 2019
* Don't reopen class, use original relationship * Don't use Ember.run
runspired
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the known to be empty behavior. It allows a second payload push without included data to keep any relationship data that the model knows about.
Related issue: #5866