Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC serializer] implements MinimumSerializerInterface #6451

Merged
merged 19 commits into from
Sep 25, 2019
Merged

[DOC serializer] implements MinimumSerializerInterface #6451

merged 19 commits into from
Sep 25, 2019

Conversation

runspired
Copy link
Contributor

Replaces #6113

Ref: #6166

@runspired runspired added 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation labels Sep 14, 2019
This was referenced Sep 14, 2019
Closed
Closed
RobbieTheWagner
RobbieTheWagner approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor question about potentially extracting the error handling to a helper to avoid a little duplication, but the rest looks good and pretty straightforward 👍

packages/store/addon/-private/system/fetch-manager.ts Show resolved Hide resolved
rwjblue
rwjblue reviewed Sep 17, 2019
View reviewed changes
packages/adapter/addon/-private/utils/serialize-into-hash.js Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
@runspired runspired mentioned this pull request Sep 17, 2019
Closed
17 tasks
@runspired runspired mentioned this pull request Sep 23, 2019
Closed
mike-north
mike-north reviewed Sep 24, 2019
View reviewed changes
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Show resolved Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts Outdated Show resolved Hide resolved
runspired and others added 3 commits September 24, 2019 16:36
@runspired @mike-north
Update packages/store/addon/-private/ts-interfaces/utils.ts
bee8fd2 
Co-Authored-By: Mike North <michael.l.north@gmail.com>
@runspired @mike-north
Update packages/store/addon/-private/ts-interfaces/minimum-serializer…
1c450f6 
…-interface.ts

Co-Authored-By: Mike North <michael.l.north@gmail.com>
@runspired @mike-north
Update packages/store/addon/-private/ts-interfaces/minimum-serializer…
b51feab 
…-interface.ts

Co-Authored-By: Mike North <michael.l.north@gmail.com>
@Gaurav0 Gaurav0 mentioned this pull request Sep 24, 2019
Merged
@runspired runspired merged commit 1e7c573 into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/serializer-documentation branch September 25, 2019 00:39
runspired added a commit that referenced this pull request Sep 25, 2019
@runspired
[DOC serializer] implements MinimumSerializerInterface (#6451)
f8d7e99
runspired added a commit that referenced this pull request Sep 25, 2019
@runspired
[DOC serializer] implements MinimumSerializerInterface (#6451)
54eeee8
This was referenced Sep 25, 2019
Merged
Merged
runspired added a commit that referenced this pull request Sep 25, 2019
@runspired
[DOC serializer] implements MinimumSerializerInterface (#6451) (#6499)
0ff38fb
runspired added a commit that referenced this pull request Sep 25, 2019
@runspired
[DOC serializer] implements MinimumSerializerInterface (#6451) (#6500)
e10c8cf
@igorT igorT removed the 🎯 beta PR should be backported to beta label Nov 4, 2019
@igorT igorT removed the 🎯 release PR should be backported to release label Dec 14, 2019
@runspired runspired removed the 🎯 canary PR is targeting canary (default) label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-the-pete pete-the-pete pete-the-pete left review comments

@mike-north mike-north mike-north left review comments

@ro0gr ro0gr ro0gr left review comments

@rwjblue rwjblue rwjblue approved these changes

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@igorT igorT Awaiting requested review from igorT

Assignees
No one assigned
Labels
🏷️ doc This PR adds/improves/or fixes documentation 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@runspired @rwjblue @pete-the-pete @mike-north @ro0gr @RobbieTheWagner @igorT