-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC serializer] implements MinimumSerializerInterface #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
🎯 beta
PR should be backported to beta
🎯 release
PR should be backported to release
🎯 canary
PR is targeting canary (default)
🏷️ doc
This PR adds/improves/or fixes documentation
labels
Sep 14, 2019
This was referenced Sep 14, 2019
Closed
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
runspired
commented
Sep 16, 2019
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
RobbieTheWagner
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor question about potentially extracting the error handling to a helper to avoid a little duplication, but the rest looks good and pretty straightforward 👍
rwjblue
reviewed
Sep 17, 2019
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
17 tasks
rwjblue
approved these changes
Sep 17, 2019
mike-north
reviewed
Sep 24, 2019
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
mike-north
reviewed
Sep 24, 2019
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
…-interface.ts Co-Authored-By: Robert Jackson <me@rwjblue.com>
runspired
force-pushed
the
feat/serializer-documentation
branch
from
September 24, 2019 22:09
7b07441
to
61fedd6
Compare
mike-north
reviewed
Sep 24, 2019
mike-north
reviewed
Sep 24, 2019
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
packages/store/addon/-private/ts-interfaces/minimum-serializer-interface.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Mike North <michael.l.north@gmail.com>
…-interface.ts Co-Authored-By: Mike North <michael.l.north@gmail.com>
…-interface.ts Co-Authored-By: Mike North <michael.l.north@gmail.com>
runspired
added a commit
that referenced
this pull request
Sep 25, 2019
runspired
added a commit
that referenced
this pull request
Sep 25, 2019
This was referenced Sep 25, 2019
runspired
added a commit
that referenced
this pull request
Sep 25, 2019
runspired
added a commit
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ doc
This PR adds/improves/or fixes documentation
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6113
Ref: #6166