Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: bump failure asset size to 75 bytes #7359

Merged
merged 5 commits into from
Oct 30, 2020
Merged

[CI]: bump failure asset size to 75 bytes #7359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d58d6f
[Ci]: bump failure asset size to 1000 bytes
snewcomer Oct 24, 2020
81a8293
Update other workflows to @v2
snewcomer Oct 24, 2020
71984c9
Asset CI job for release PRs
snewcomer Oct 24, 2020
42629a7
Simply bump up to 75b with no special release check
snewcomer Oct 30, 2020
f86083a
minor formatting
snewcomer Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/asset-size-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
asset-size-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2-beta
with:
node-version: 12.x
repo-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -92,13 +92,13 @@ jobs:
node ./bin/asset-size-tracking/generate-diff.js ./control-data-no-rollup.json ./experiment-data-no-rollup.json | tee tmp/asset-sizes/diff-no-rollup.txt
- name: Upload Dist Artifacts
if: failure() || success()
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v2
with:
name: dists
path: packages/-ember-data/dists
- name: Upload Report Artifacts
if: failure() || success()
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v2
with:
name: reports
path: tmp/asset-sizes
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
test-all-deprecations:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v2
- uses: actions/setup-node@v2-beta
with:
node-version: 12.x
repo-token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -33,8 +33,8 @@ jobs:
scenario: [ember-beta, ember-canary]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 12.x
repo-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/relationship-performance-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
relationship-performance-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2-beta
with:
node-version: 12.x
repo-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions bin/asset-size-tracking/generate-diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ const Library = require('./src/library');
const parseModules = require('./src/parse-modules');
const getBuiltDist = require('./src/get-built-dist');

const library_failure_threshold = 15;
const package_warn_threshold = 0;

let BASE_DATA_FILE = process.argv[2] || false;
let NEW_DATA_FILE = process.argv[3] || false;

let library_failure_threshold = 75;
const package_warn_threshold = 0;

if (!BASE_DATA_FILE) {
BASE_DATA_FILE = './current-data.json';
}
Expand Down