-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup]: Remove FULL_LINKS_ON_RELATIONSHIPS #7393
Conversation
2f151d9
to
4a72fdf
Compare
Performance Report for 38cbd3c Relationship Analysis
|
Asset Size Report for 38cbd3c IE11 Builds EmberData shrank by 23.0 B (9.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (IE11)
Modern Builds EmberData shrank by 23.0 B (9.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) EmberData shrank by 22.0 B (56.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
|
@@ -176,7 +176,6 @@ export default { | |||
IDENTIFIERS: true, | |||
REQUEST_SERVICE: null, | |||
CUSTOM_MODEL_CLASS: null, | |||
FULL_LINKS_ON_RELATIONSHIPS: true, | |||
RECORD_ARRAY_MANAGER_IDENTIFIERS: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to leave this as true, in case any addon/app was checking the value cc @rwjblue
@@ -37,7 +37,6 @@ export const RECORD_DATA_STATE = featureValue(FEATURES.RECORD_DATA_STATE); | |||
export const REQUEST_SERVICE = featureValue(FEATURES.REQUEST_SERVICE); | |||
export const IDENTIFIERS = featureValue(FEATURES.IDENTIFIERS); | |||
export const CUSTOM_MODEL_CLASS = featureValue(FEATURES.CUSTOM_MODEL_CLASS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
eaafa3b
to
38cbd3c
Compare
PR to turn on - #6966