Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (private) implement basic field support for schema-record #8935

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Sep 28, 2023

Implements simple attributes. This package is currently private and never published so that we can land work incrementally.

  • no type
  • type
  • defaultValue
  • options

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Sep 28, 2023
@runspired runspired self-assigned this Sep 28, 2023
@runspired runspired merged commit 751e16f into main Sep 29, 2023
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the schema-record-work branch September 29, 2023 01:46
BoussonKarel pushed a commit to BoussonKarel/data that referenced this pull request Oct 6, 2023
…rjs#8935)

* stash schema record work

* all the TS things

* more impl work

* make defaultValue work nice

* fixup a bunch of tests

* fix lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant