Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel polyfill broken in 7.26.10 #429

Closed
nickschot opened this issue Dec 17, 2021 · 5 comments
Closed

Babel polyfill broken in 7.26.10 #429

nickschot opened this issue Dec 17, 2021 · 5 comments

Comments

@nickschot
Copy link

Specifying

  // ember-cli-build.js
  let app = new EmberApp(defaults, {
    'ember-cli-babel': {
      includePolyfill: true,
    },
  });

will cause the following error on build:

Build Error (SourceMapConcat)

ENOENT: no such file or directory, open '/var/folders/7h/82hn6hyn1bngg96_xvhlmq040000gn/T/broccoli-34311LQfVtgUc1OgD/out-262-broccoli_debug_debug_5_vendor_js/vendor/babel-polyfill/polyfill.js'

Minimal reproduction: https://github.com/nickschot/babel-polyfill-repro

@Adonis320
Copy link

Affects versions 7.26.7 and upwards

@rwjblue
Copy link
Member

rwjblue commented Dec 17, 2021

Hmph. Why? This is strange, we didn't change anything RE: the polyfill in these versions 🤔

@nickschot
Copy link
Author

Good question 😂 I ran into it testing the updated version to see if my private class property issues were resolved.

@chriskrycho
Copy link
Contributor

I suspect it was an “unclean revert”1: ea752c4 reverted 0d47e8b, but did not revert the bump to @babel/preset-env that was included there. Presumably there’s a difference in what the updated @babel/preset-env is requiring or not for the polyfill.

Footnotes

  1. this sounds hilarious 😂

MikiDi added a commit to kanselarij-vlaanderen/frontend-valvas that referenced this issue Dec 21, 2021
@rwjblue
Copy link
Member

rwjblue commented Dec 22, 2021

Sorry about this y'all, fixed in https://github.com/babel/ember-cli-babel/releases/tag/v7.26.11

@rwjblue rwjblue closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants