provide name for hbs template only components #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
changed the title
RobbieTheWagner
approved these changes
Jul 1, 2024
|
Seems logical. We need to get beta and canary passing though. It would also be good to add a test case for this. |
|
canary & beta are failing because we cannot patch glimmer vm anymore to add the |
|
@patricklx can you please rebase this so we can skip that test? |
RobbieTheWagner
approved these changes
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for template only components coming from .hbs files we can know the name by using the moduleName.
this is when gjs/gts files import hbs template only components. Or also when references via js. e.g
<this.MyTemplateOnlyComponent />