Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab order for "Module" and "Filter" items is reversed in toolbar #633

Closed
eddylu94 opened this issue Jan 31, 2020 · 1 comment
Closed

Tab order for "Module" and "Filter" items is reversed in toolbar #633

eddylu94 opened this issue Jan 31, 2020 · 1 comment

Comments

@eddylu94
Copy link

The toolbar includes two filters, Module and Filter:

image

One will notice that, while tabbing through the application, the Filter item will be focused upon first before the Module item. This is because the Filter item (class="qunit-filter") is listed before the Module filter (class="qunit-modulefilter") in the DOM structure:

<form class="qunit-modulefilter">...</form>
<form class="qunit-filter">...</form>

This reverse ordering is a consequence of using CSS 'float' style, where visual order is inverted from that of the DOM order.

@eddylu94
Copy link
Author

Closing issue as it should belong to the general qunit project:
qunitjs/qunit#1428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant