Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab order for "Module" and "Filter" items is reversed in toolbar #1428

Closed
eddylu94 opened this issue Jan 31, 2020 · 1 comment
Closed

Tab order for "Module" and "Filter" items is reversed in toolbar #1428

eddylu94 opened this issue Jan 31, 2020 · 1 comment
Labels
Component: HTML Reporter Type: Bug Something isn't working right.

Comments

@eddylu94
Copy link
Contributor

eddylu94 commented Jan 31, 2020

Tell us about your runtime:

  • QUnit version: v2.9.2
  • What environment are you running QUnit in? (e.g., browser, Node): Edge, Chrome
  • How are you running QUnit? (e.g., script, testem, Grunt): Script

What are you trying to do?

Code that reproduces the problem:

.qunit-filter,
#qunit-modulefilter {
	float: right;
	position: relative;
	margin-left: 1em;
}

If you have any relevant configuration information, please include that here:

The toolbar includes two filters, Module and Filter:

image

One will notice that, while tabbing through the application, the Filter item will be focused upon first before the Module item. This is because the Filter item (class="qunit-filter") is listed before the Module filter (class="qunit-modulefilter") in the DOM structure:

<form class="qunit-modulefilter">...</form>
<form class="qunit-filter">...</form>

This reverse ordering is a consequence of using CSS 'float' style, where visual order is inverted from that of the DOM order.

What did you expect to happen?

The Module toolbar item should be focused upon before the Filter toolbar item.

What actually happened?

The tab order is reversed.

eddylu94 added a commit to eddylu94/qunit that referenced this issue Jan 31, 2020
Resolve Issue qunitjs#1428
Issue qunitjs#1428: Tab order for "Module" and "Filter" items is reversed in toolbar
@trentmwillis trentmwillis added Component: HTML Reporter Type: Bug Something isn't working right. labels Feb 5, 2020
trentmwillis pushed a commit that referenced this issue Feb 8, 2020
Resolve Issue #1428
Issue #1428: Tab order for "Module" and "Filter" items is reversed in toolbar
@eddylu94
Copy link
Contributor Author

eddylu94 commented Feb 8, 2020

Closing issue as it has been resolved in commit 95226b7

@eddylu94 eddylu94 closed this as completed Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: HTML Reporter Type: Bug Something isn't working right.
Development

No branches or pull requests

2 participants