Correct tab order for toolbar filters #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve Issue qunitjs#1428 Issue qunitjs#1428: Tab order for "Module" and "Filter" items is reversed in toolbar
|
|
trentmwillis
approved these changes
Feb 5, 2020
|
@trentmwillis From local testing, the visual appearance of the UI remains unaltered when the changes are applied |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this pull request is to correct the tab order for the toolbar filters. Currently, the tab order for the Module and Filter items in the toolbar are in reverse order (right-to-left for English) as described by Issue #1428:
Issue #1428 - Tab order for "Module" and "Filter" items is reversed in toolbar
The changes applied in this pull request wrap the two toolbar filters into a single container SPAN element. This new container has a
float: rightstyle that acts as a substitute for the originalfloatstyles assigned to each of the two toolbar filters. When the individualfloatstyles are removed from the toolbar filters, then the order of the corresponding DOM elements (also the tab order) for these filters will no longer be the reverse of the visual order.