Wrong context in asyncTest (using callbacks given to moduleFor instead of extended callbacks)

[huafu]

Using moduleFor is extending the 3rd argument (callbacks) to inject subject for example. This works for setup, teardown and any test, but any asyncTest has the un-modified callbacks given as 3rd argument to moduleFor instead of the one where subject has been injected.

In result, calling this.subject() in an asyncTest is failing since subject is then undefined

[stefanpenner]

@huafu the idea is to use promises, and return promises in the main callback whenever one would need an async test. This typically provides a nicer asyncTest experience as it does all the start/stop balancing for you and also preserves context.

[huafu]

Sorry but do you have an example of how to do an async test with promises and this.subject even very simple, or link to where there might be one somewhere?

[rwjblue]

test('do something async', function() {
  return new Ember.RSVP.Promise(function(resolve, reject) {
    /* do something that does async */
    setTimeout(function() {
      /* when the async is done */
      resolve();
    }, 10);
  });
});

[rwjblue]

https://github.com/rwjblue/ember-qunit/blob/master/README.md#async-example

[huafu]

Haha as simple as this! Thank you I wouldn't think it was that simple, forgot test where waiting for promise and other delayed stuff to finish, thanks a lot!

Huafu Gandon
Head of Tech, Sovolve, LLC
Skype: pedroleouf
www.sovolve.com
Social Evolution, Accelerated

Try Panomira.
You'll never look at yourself the same way again.

On 13 oct. 2014, at 19:53, Robert Jackson notifications@github.com wrote:

Closed #98.

—
Reply to this email directly or view it on GitHub.

[stefanpenner]

Awesomely the latest Qunit will support this promise behavior right out of the box!