Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't enough to get
@ember/test-helpers
working.We need to drop support for node 14 as well, which means, we may as well do a bunch of things that could be breaking, like the v2 conversion, which already drops node 14.
These PRs should be merged/reviewed in order, as they build on each other, so they'll get bigger and bigger unless the prior PRs are merged.
my preference would be to merge those above 4, and ignore this PR until the end (due to conflict resolution concerns)