Better exception messages on phantomjs #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions on phantomjs have a `stack` property that does not contain the exception message itself. Which causes us to print only the stack without the actual error message. This change ensures that the error message must appear withinn our output. I'm not sure how to test this -- mocking out `ok` while also using `ok` seems very headsplody.
|
A human smoke test here seems good to me. Can you screenshot a before/after example of what this look like with |
|
Before: After: |
|
ZOMG Thank you! |
rwjblue
added a commit
that referenced
this pull request
Sep 17, 2015
Better exception messages on phantomjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions on phantomjs have a
stackproperty that does not containthe exception message itself. Which causes us to print only the stack
without the actual error message whenever a test returns a rejected promise.
This change ensures that the error message must appear within our output.
I'm not sure how to test this -- mocking out
okwhile also usingokseems very headsplody.