Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Qunit module available as 'ember-qunit' export #245

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

zzarcon
Copy link
Contributor

@zzarcon zzarcon commented Sep 29, 2016

Just to be consistent with the other other parts and because I think it's useful to be uses in tests like

import {module} from 'ember-qunit';

module('My custom class test...');

Instead of using window.module which doesn't work anymore or QUnit.module, also in some cases in which moduleFor... doesn't fit.

@rwjblue
Copy link
Member

rwjblue commented Sep 29, 2016

Awesome, thank you!

@rwjblue rwjblue merged commit af42d1c into emberjs:master Sep 29, 2016
@zzarcon
Copy link
Contributor Author

zzarcon commented Sep 29, 2016

@rwjblue yeah! thanks you for the repo and sorry for the spam 🚀

@josemarluedke
Copy link

@rwjblue any change we can get a release out containing this?

@rwjblue
Copy link
Member

rwjblue commented Oct 26, 2016

@josemarluedke - Done!

@zzarcon
Copy link
Contributor Author

zzarcon commented Oct 26, 2016

@rwjblue thanks!

@josemarluedke
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants